Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update note feature extraction for dynamic features #274

Merged
merged 1 commit into from
Jun 15, 2023
Merged

update note feature extraction for dynamic features #274

merged 1 commit into from
Jun 15, 2023

Conversation

sildater
Copy link
Member

removes constant activation for dynamic score features. e.g. crescendi will no just start at 0, ramp up to 1 and drop back to zero at their end, not stay constant until a constant loudness direction is found.
This PR addresses the ramping behavior in #244 and also the problems mentioned in #272

This was linked to issues Jun 15, 2023
Unexpected drop in loudness_decr ramp #244
Closed
several conditions are never reached in feature_function_activation #272
Closed
manoskary
manoskary approved these changes Jun 15, 2023
View reviewed changes
Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR looks good, it addresses issues about the dynamics ramp constantly increasing. Instead, the new approach informs about the beginning an end boundaries of a dynamics ramp such as crescendo or diminuendo

@manoskary manoskary merged commit b1dc071 into develop Jun 15, 2023
@sildater sildater deleted the non_constant_features branch July 19, 2023 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manoskary manoskary manoskary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

several conditions are never reached in feature_function_activation Unexpected drop in loudness_decr ramp
2 participants
@sildater @manoskary