Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kern import fix #160

Merged
merged 7 commits into from
Oct 20, 2022
Merged

Kern import fix #160

merged 7 commits into from
Oct 20, 2022

Conversation

manoskary
Copy link
Member

This PR addresses issues #158 and #159 and other minor bug fixes.

@manoskary manoskary added the bug Something isn't working label Oct 10, 2022
This was linked to issues Oct 10, 2022
@sildater sildater self-requested a review October 11, 2022 09:19
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 80.59% // Head: 80.55% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (d5fa5f9) compared to base (d1bee81).
Patch coverage: 46.15% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #160      +/-   ##
===========================================
- Coverage    80.59%   80.55%   -0.05%     
===========================================
  Files           63       63              
  Lines        10278    10289      +11     
===========================================
+ Hits          8284     8288       +4     
- Misses        1994     2001       +7     
Impacted Files Coverage Δ
partitura/score.py 79.55% <ø> (ø)
partitura/utils/music.py 68.22% <40.00%> (-0.22%) ⬇️
partitura/io/importmusicxml.py 74.04% <42.85%> (-0.36%) ⬇️
partitura/io/importkern.py 85.80% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manoskary manoskary requested a review from sildater October 14, 2022 09:54
partitura/io/importmusicxml.py Outdated Show resolved Hide resolved
@manoskary manoskary linked an issue Oct 19, 2022 that may be closed by this pull request
@sildater sildater merged commit 58145e0 into develop Oct 20, 2022
@sildater sildater deleted the kern_import_fix branch October 20, 2022 07:36
@manoskary manoskary mentioned this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with musicxml Import Note array from note list with empty voice bug. Kern import fails
3 participants