Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reference-based midi pitch to freq #163

Merged
merged 2 commits into from
Oct 20, 2022
Merged

add reference-based midi pitch to freq #163

merged 2 commits into from
Oct 20, 2022

Conversation

sildater
Copy link
Member

adds support for reference-based and tempered computation of frequencies from midi pitch information. improves over the previous version by 1) including arbitrary references 2) support of non-invertible temperament ratios tables (for arbitrary tables subtracting a maj2nd might be different from adding a min7th and subtracting an octave)

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2022

Codecov Report

Base: 80.59% // Head: 80.52% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (32787a3) compared to base (b1ea05e).
Patch coverage: 9.09% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #163      +/-   ##
===========================================
- Coverage    80.59%   80.52%   -0.08%     
===========================================
  Files           63       63              
  Lines        10278    10289      +11     
===========================================
+ Hits          8284     8285       +1     
- Misses        1994     2004      +10     
Impacted Files Coverage Δ
partitura/utils/synth.py 67.17% <9.09%> (-5.33%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@manoskary manoskary self-requested a review October 19, 2022 15:43
@manoskary
Copy link
Member

Very nice addition. Do you think a unitest or adding an example to the docs would be useful for this?

@sildater
Copy link
Member Author

I thought it was overkill, but I can add one so the coverage doesn't go down :)

@manoskary manoskary merged commit fed36af into develop Oct 20, 2022
@sildater sildater deleted the temperaments branch October 20, 2022 07:36
@manoskary manoskary mentioned this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants