Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #248 #253

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Fix Issue #248 #253

merged 2 commits into from
Jun 5, 2023

Conversation

CarlosCancino-Chacon
Copy link
Member

This pull request closes issue #248, i.e., fixes the behavior of the clip_note_off argument in slice_ppart_by_time.

The pull request consists of

  • The bug fix itself
  • An upgraded test checking both the clip_note_off and reindex_notes arguments of slice_ppart_by_time

@CarlosCancino-Chacon CarlosCancino-Chacon added the bug Something isn't working label Jun 5, 2023
@CarlosCancino-Chacon CarlosCancino-Chacon self-assigned this Jun 5, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 91.66% and project coverage change: +0.04 🎉

Comparison is base (59cbe3a) 85.00% compared to head (6731eeb) 85.04%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #253      +/-   ##
===========================================
+ Coverage    85.00%   85.04%   +0.04%     
===========================================
  Files           72       72              
  Lines        12653    12667      +14     
===========================================
+ Hits         10756    10773      +17     
+ Misses        1897     1894       -3     
Impacted Files Coverage Δ
partitura/utils/music.py 74.48% <50.00%> (+0.30%) ⬆️
tests/test_utils.py 98.13% <100.00%> (+0.12%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor correction to address issue #248 by adding missing argument for cutoff.
Also some addition to test utils and minor documentation typo corrections.

@manoskary manoskary merged commit a0f5b3b into develop Jun 5, 2023
@CarlosCancino-Chacon CarlosCancino-Chacon deleted the fix_248 branch June 5, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants