Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new score attributes in match export, new score properties, misc fixes #303

Merged
merged 10 commits into from
Sep 22, 2023

Conversation

huispaty
Copy link
Collaborator

@huispaty huispaty commented Aug 3, 2023

  • match export:
    • added new scoreprop_line for tempo_indication score meta information using optional param 'tempo_indication'
    • added missing grace score note attribute
    • added new score attribute voice_overlap for deletion-score notes that have a voice-overlapping (aligned) score note
    • added new score attribute diff_score_version for score notes that reflect a special score version
  • score, musicxml import: new score attributes capturing score meta information: work_title, work_number, title_number , movement_number
  • midi import: minor fix for note IDs (numbering starting from 1 instead of 0)
  • midi export: new optional merge_tracks_save param
  • test_match_import.py: minor fix for default midiClockUnits rate, updated mozart_k265_var1.match file

manoskary and others added 3 commits June 10, 2023 11:48
Release 1.3.0 merge to main
…attributes, note id fix in load_performance_midi, optional track merging param in save_performance_midi
@manoskary manoskary changed the base branch from main to develop August 3, 2023 15:30
@manoskary
Copy link
Member

Are any of the proposed fixes related to existing issues?

Copy link
Member

@manoskary manoskary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces a lot of useful features and fixes from midi merging tracks, to matchfile edits, to score new attributes. I wasn't aware of about discussion of these changes so I would also request a review from another person. Also matchiline changes should probably be reviewed by somebody else than me. This review addresses mostrly styling, minor comments and questions.

partitura/io/exportmatch.py Outdated Show resolved Hide resolved
partitura/score.py Show resolved Hide resolved
partitura/io/importmidi.py Outdated Show resolved Hide resolved
partitura/io/exportmidi.py Outdated Show resolved Hide resolved
partitura/io/exportmatch.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 63.09% and project coverage change: -0.38% ⚠️

Comparison is base (36450da) 85.36% compared to head (4d73f13) 84.98%.
Report is 27 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #303      +/-   ##
===========================================
- Coverage    85.36%   84.98%   -0.38%     
===========================================
  Files           79       80       +1     
  Lines        13590    13739     +149     
===========================================
+ Hits         11601    11676      +75     
- Misses        1989     2063      +74     
Files Changed Coverage Δ
partitura/directions.py 78.49% <ø> (ø)
partitura/io/matchlines_v1.py 82.38% <ø> (ø)
tests/__init__.py 100.00% <ø> (ø)
tests/test_tonal_tension.py 100.00% <ø> (ø)
partitura/io/matchfile_utils.py 92.87% <28.00%> (-4.59%) ⬇️
partitura/io/importmidi.py 83.94% <50.00%> (ø)
partitura/io/exportmatch.py 78.30% <64.70%> (-4.84%) ⬇️
partitura/io/exportmidi.py 90.54% <66.66%> (-0.37%) ⬇️
tests/test_pianoroll.py 99.45% <66.66%> (-0.55%) ⬇️
partitura/io/importmusicxml.py 79.97% <80.00%> (+0.39%) ⬆️
... and 3 more

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@manoskary manoskary self-requested a review August 8, 2023 12:29
partitura/io/exportmatch.py Outdated Show resolved Hide resolved
tests/__init__.py Outdated Show resolved Hide resolved
tests/test_pianoroll.py Outdated Show resolved Hide resolved
tests/test_xml.py Outdated Show resolved Hide resolved
tests/test_xml.py Outdated Show resolved Hide resolved
@huispaty
Copy link
Collaborator Author

huispaty commented Aug 8, 2023

The PR is not linked to any reported issues but addresses changes/change requests originating from discussions with @neosatrapahereje (match export) and @sildater (score attributes).

@huispaty huispaty added the enhancement New feature or request label Sep 22, 2023
@huispaty huispaty requested a review from manoskary September 22, 2023 10:35
@manoskary manoskary merged commit 4838419 into develop Sep 22, 2023
@huispaty huispaty deleted the match_export branch October 11, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants