-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new score attributes in match export, new score properties, misc fixes #303
Conversation
Release 1.3.0 merge to main
Release 1.3.1
…attributes, note id fix in load_performance_midi, optional track merging param in save_performance_midi
Are any of the proposed fixes related to existing issues? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR introduces a lot of useful features and fixes from midi merging tracks, to matchfile edits, to score new attributes. I wasn't aware of about discussion of these changes so I would also request a review from another person. Also matchiline changes should probably be reviewed by somebody else than me. This review addresses mostrly styling, minor comments and questions.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #303 +/- ##
===========================================
- Coverage 85.36% 84.98% -0.38%
===========================================
Files 79 80 +1
Lines 13590 13739 +149
===========================================
+ Hits 11601 11676 +75
- Misses 1989 2063 +74
☔ View full report in Codecov by Sentry. |
The PR is not linked to any reported issues but addresses changes/change requests originating from discussions with @neosatrapahereje (match export) and @sildater (score attributes). |
tempo_indication
score meta information using optional param 'tempo_indication'grace
score note attributevoice_overlap
for deletion-score notes that have a voice-overlapping (aligned) score notediff_score_version
for score notes that reflect a special score versionwork_title
,work_number
,title_number
,movement_number
merge_tracks_save
paramtest_match_import.py
: minor fix for default midiClockUnits rate, updatedmozart_k265_var1.match
file