Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dcml annotation parser #345

Merged
merged 65 commits into from
Jul 16, 2024
Merged

Dcml annotation parser #345

merged 65 commits into from
Jul 16, 2024

Conversation

manoskary
Copy link
Member

@manoskary manoskary commented Jan 30, 2024

Import for DCML corpora tsv files

DONE

  • functional import with the possibility to include only notes, or notes, measures and harmony.
  • Added optional dependency in pandas
  • Some updates on score classes such as Cadences, Roman numerals and Phrases.
  • Updated the estimate symbolic duration function in music.py.
  • Move globals from partitura.utils.music to separate script called partitura.utils.globals to avoid circular import errors. (This will be done in a following PR after this one is merged to not break other components).
  • Included infer root note, bass note from Roman Numeral and Chord Symbol strings.
  • Included validity checks for Roman Numeral Symbols and Cadence types.
  • Updates and fixes on note transposition

TODOs (For new PRs)

  • Remove pandas dependency:
    This will be planned for later using numpy.genfromtxt. It can be done but the process is much more complicated because it transforms many strings to byte strings and it will take some major restructuring. For now the code raises a warning that pandas is required. For the future, we replace with numpy.genfromtxt and replace the warning. A relevant Issue will be opened.
  • Notebook and github discussion with documentation about RomanNumerals and Intervals and such

@manoskary manoskary added the enhancement New feature or request label Jan 30, 2024
@manoskary manoskary requested a review from sildater January 30, 2024 10:41
@manoskary manoskary self-assigned this Jan 30, 2024
@manoskary manoskary linked an issue Jan 30, 2024 that may be closed by this pull request
@manoskary manoskary marked this pull request as ready for review April 24, 2024 08:48
@manoskary manoskary requested review from fosfrancesco and removed request for huispaty June 13, 2024 12:36
partitura/io/importdcml.py Outdated Show resolved Hide resolved
partitura/io/importdcml.py Show resolved Hide resolved
partitura/io/importdcml.py Show resolved Hide resolved
partitura/io/importdcml.py Outdated Show resolved Hide resolved
partitura/io/importdcml.py Show resolved Hide resolved
partitura/score.py Show resolved Hide resolved
partitura/score.py Outdated Show resolved Hide resolved
partitura/score.py Show resolved Hide resolved
partitura/score.py Outdated Show resolved Hide resolved
@fosfrancesco
Copy link
Member

The PR is good, I'm requesting some cosmetic changes for better code readability.

@manoskary manoskary requested a review from fosfrancesco July 3, 2024 13:08
@fosfrancesco fosfrancesco merged commit cd499eb into develop Jul 16, 2024
3 checks passed
@manoskary manoskary mentioned this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parser for scores and annotations in dcml corpora
4 participants