-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dcml annotation parser #345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR for Release 1.4.0
PR for Release 1.4.1
…ut octave) while maintining a correct pitch spelling.
Updated optional dependencies to include pandas.
…o warning. It will be fixed with introduced Vocabulary on chords.
…l_annotation_parser
# Conflicts: # partitura/utils/music.py
# Conflicts: # partitura/utils/synth.py
# Conflicts: # partitura/utils/music.py
manoskary
commented
Jun 24, 2024
manoskary
commented
Jun 24, 2024
manoskary
commented
Jun 24, 2024
manoskary
commented
Jun 24, 2024
manoskary
commented
Jun 24, 2024
manoskary
commented
Jun 24, 2024
manoskary
commented
Jun 24, 2024
manoskary
commented
Jun 28, 2024
fosfrancesco
requested changes
Jul 1, 2024
The PR is good, I'm requesting some cosmetic changes for better code readability. |
fosfrancesco
approved these changes
Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import for DCML corpora tsv files
DONE
music.py
.partitura.utils.music
to separate script calledpartitura.utils.globals
to avoid circular import errors. (This will be done in a following PR after this one is merged to not break other components).TODOs (For new PRs)
This will be planned for later using
numpy.genfromtxt
. It can be done but the process is much more complicated because it transforms many strings to byte strings and it will take some major restructuring. For now the code raises a warning that pandas is required. For the future, we replace withnumpy.genfromtxt
and replace the warning. A relevant Issue will be opened.