Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for example notebook regressions in CI #375

Closed
mark-koch opened this issue Aug 12, 2024 · 0 comments · Fixed by #383
Closed

Check for example notebook regressions in CI #375

mark-koch opened this issue Aug 12, 2024 · 0 comments · Fixed by #383
Assignees
@mark-koch

Comments

@mark-koch
Copy link
Collaborator

mark-koch commented Aug 12, 2024 •
edited
Loading

We can use https://pytest-notebook.readthedocs.io/en/latest/

This requires making the notebook outputs deterministic (currently, error messages mention a temporary file as the error location). See #381
This was referenced Aug 12, 2024
Merged
Closed
@mark-koch mark-koch self-assigned this Aug 13, 2024
github-merge-queue bot pushed a commit that referenced this issue Aug 13, 2024
@mark-koch
fix: Fix and update demo notebook (#376)
23b2a15 
Closes #371.

See
https://github.com/CQCL/guppylang/blob/fix/demo-notebook/examples/demo.ipynb
for the rendered notebook.

Drive-by: Add `bool.__xor__` method for the example.

We should check for notebook regressions in CI to avoid breaking the
example in the future. See #375
@mark-koch mark-koch mentioned this issue Aug 13, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Aug 21, 2024
@mark-koch
test: Add test to detect notebook regressions (#383)
c2ab65f 
Closes #375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-koch mark-koch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add test to detect notebook regressions CQCL/guppylang
1 participant
@mark-koch