feat: Add Place union and lower AST to it during checking
#289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mark-koch
requested review from
aborgna-q and
ss2165
and removed request for
a team and
aborgna-q
ss2165
reviewed
Jul 9, 2024
guppylang/checker/core.py
Outdated
| from guppylang.definition.struct import StructField | ||
|
|
||
|
|
||
| #: A "place" is a description for a storage location of a local value that users |
There was a problem hiding this comment.
Suggested change
| #: A "place" is a description for a storage location of a local value that users | |
| #: A "place" is a description for a storage location of a local value that users |
guppylang/checker/stmt_checker.py
Outdated
| # For now we complain if someone tries to assign to something that | ||
| # is not a place (e.g. `f().a = 4`) | ||
| raise GuppyError( | ||
| "Assigning to this expression is not supported yet", value |
There was a problem hiding this comment.
worth more details on why not, otherwise I don't necessarily know how to fix it
There was a problem hiding this comment.
I meant more details in the error message
There was a problem hiding this comment.
Ops yeah I misunderstood. I added a fix suggestion to the error message
| "Mutation of classical fields is not supported yet", lhs | ||
| ) | ||
| place = FieldAccess(value.place, struct_ty.field_dict[attr], lhs) | ||
| return with_loc(lhs, PlaceNode(place=place)) | ||
|
|
||
| # The only other thing we support right now are tuples |
ss2165
requested changes
Jul 10, 2024
ss2165
approved these changes
Jul 15, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 24, 2024
This is the feature branch for enabling struct field access and mutation of linear fields. Closes #276, closes #280, and closes #156. The difficult bit is that we want to track linearity of individual struct fields separately (akin to Rust's partial moves): ```python @guppy.struct class MyStruct: q1: qubit q2: qubit x: int def main(s: MyStruct): q = h(s.q1) t = h(s.q2) # Using s.q2 is fine, only s.q1 has been used y = s.x + s.x # Classical fields can be used multiple times use(s) # Error: Linear fields of s have already been used ... ``` This is the plan: * We introduce a new notion called `Place`: A place is a description for a storage location of a local value that users can refer to in their program. Roughly, these are values that can be lowered to a static wire within the Hugr and are tracked separately when checking linearity. * For the purposes of this PR, a place is either a local variable or a field projection of another place that holds a struct. I.e. places are paths `a.b.c.d` of zero or more nested struct accesses. In the future, indexing into an array etc will also become a place. * During type checking, we figure out which AST nodes correspond to places and annotate them as such * For linearity checking, we run a liveness analysis pass that tracks usage and assignment of places across the CFG. This way, linearity of different struct fields is tracked individually. * When compiling to Hugr, we keep track of a mapping from places to wires/ports Tracked PRs: * #288: Precursor PR to generalise our program analysis framework to run on places in the future. * #289: Adds the `Place` type and implements the type checking logic to turn `ast.Name` and `ast.Attribute` nodes into places. * #290: Update linearity checker to operate on places instead of variables * #291: Lower places to Hugr * #292: Some missing pieces to handle nested functions correctlt * #293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #295 for context.
The tests are at #293