-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update statement checker to use new diagnostics #621
Conversation
1a22cb3
to
0fd094c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/diagnostics #621 +/- ##
====================================================
+ Coverage 92.18% 92.20% +0.02%
====================================================
Files 65 64 -1
Lines 7201 7060 -141
====================================================
- Hits 6638 6510 -128
+ Misses 563 550 -13 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error messages look way more friendly now! Had a question about one of them. Unsure if it's even part of this PR.
13 | @guppy(module) | ||
14 | def foo(s: MyStruct) -> None: | ||
15 | s.z = 2 | ||
| ^ Attribute `z` not found on type `int` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be an easier read if this error was:
| ^ Attribute `z` not found on type `int` | |
| ^ Attribute `z` of type `int` not found |
or even better
| ^ Attribute `z` not found on type `int` | |
| ^ `MyStruct` has no attribute `z` of type `int` |
I actually don't see the relevance of the inferred type here, the error message on the left is quite descriptive as is. Perhaps I am missing some context here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops yes it's supposed to say "MyStruct" instead of "int" 👍
Closes #540