fix: Allow string py expressions in result and panic #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
==========================================
+ Coverage 92.94% 92.98% +0.03%
==========================================
Files 71 71
Lines 8224 8226 +2
==========================================
+ Hits 7644 7649 +5
+ Misses 580 577 -3 ☔ View full report in Codecov by Sentry. |
tatiana-s
changed the title
mark-koch
reviewed
Jan 8, 2025
| | ^^^^^^^^^^^^^ Expected a string literal | ||
| | ^^^^^^^^^^^^^ Binary operator `+` not defined for `str` and `str` |
There was a problem hiding this comment.
Can you update this test so it still catches the non static error. Something like
panic("foo" if y else "bar", y)| | ^^^^^^^^^^^^^ Expected a string literal | ||
| | ^^^^^^^^^^^^^ Binary operator `+` not defined for `str` and `str` |
mark-koch
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.