Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose sealed traits in hugr-core #1121

Closed
aborgna-q opened this issue May 28, 2024 · 0 comments · Fixed by #1122
Closed

Expose sealed traits in hugr-core #1121

aborgna-q opened this issue May 28, 2024 · 0 comments · Fixed by #1122
Assignees
@aborgna-q

Comments

@aborgna-q
Copy link
Collaborator

tket2 uses low-level hugr methods like HugrMutInternals::replace_op via some super-trait hackery. We want to move away from that, but we require access to the trait definition first.

The traits should only be exposed in hugr-core, and not in the hugr re-exports.
@aborgna-q aborgna-q self-assigned this May 28, 2024
@aborgna-q aborgna-q mentioned this issue May 28, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 29, 2024
@aborgna-q
feat(hugr-core): Unseal and make public the traits HugrInternals an…
f97ba06 
…d `HugrMutInternals` (#1122)

Exposes `HugrInternals` and `HugrMutInternals` in
`hugr_core::hugr::internal` (but not in `hugr`).

Closes #1121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(hugr-core): Unseal and make public the traits HugrInternals and HugrMutInternals CQCL/hugr
1 participant
@aborgna-q