Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Op signature function + type extraction for parents + sumtuples #1198

Closed
Tracked by #486
ss2165 opened this issue Jun 17, 2024 · 0 comments · Fixed by #1199
Closed
Tracked by #486

Op signature function + type extraction for parents + sumtuples #1198

ss2165 opened this issue Jun 17, 2024 · 0 comments · Fixed by #1199
Assignees
@ss2165

Comments

@ss2165
Copy link
Member

ss2165 commented Jun 17, 2024

No description provided.

This was referenced Jun 17, 2024
Closed
Merged
github-merge-queue bot pushed a commit that referenced this issue Jun 18, 2024
@ss2165 @mark-koch
feat(hugr-py): only require input type annotations when building (#1199)
2bb079f 
Closes #1198

- ops have to report their signature, but may be initialised incomplete
- dataflow ops have hooks to update themselves based on the types
flowing in to them
- parent ops can update themselves based on the types flowing out of
them
- Tag needs to know all possible variants, can't infer from input types
- calculate cfg outputs by looking at output types of blocks that
connect to exit block

reviewing commit by commit might be easier

---------

Co-authored-by: Mark Koch <[email protected]>
@ss2165 ss2165 self-assigned this Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ss2165 ss2165

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(hugr-py): only require input type annotations when building CQCL/hugr
1 participant
@ss2165