-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "requires binary" flag to opdef signatures. #1361
Comments
How do I interpret this? Does this describe the current situation, or the desired state? If the latter, which bits are new? Looking at the current
However not clear how this relates to the issue here. A second possible goal is to replace each of the |
Ah, or does this just relate to serialization format? |
this relates to just serialised yeah, I've been thinking of those as "declarations" (as opposed to "definitions" that may be backed by executable code) |
Fear not the diff, mostly schema update. - Define a Pydantic model and serialised schema for extensions. - Update the rust `SignatureFunc` serialisation to be compatible with this. - Serialized extension "declarations" can state they require binary compute or validation functions. `SignatureFunc` reports this if they are missing, and it is up to the caller (typically validation) to decide how to recover from this. Closes #1360 Closes #1361 Addresses parts of #1228 Best reviewed as individual commits. BREAKING CHANGE: `TypeDefBound` uses struct-variants for serialization. `SignatureFunc` now has variants for missing binary functions, and serializes in to a new format that indicates expected binaries.
Operations in Extension declarations can state one of:
The text was updated successfully, but these errors were encountered: