You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
let new_signature = dfg_optype.dataflow_signature();
However if the replacement had any disconnected outputs or multi-connected outputs this would fail because the current signature is calculated by iterating of the subgraph edges.
Disabling the signature check for the outputs is not enough because subsequent logic iterates over the subgraph outputs and misses out the disconnected port.
The text was updated successfully, but these errors were encountered:
ss2165
changed the title
bug: SiblingSubgraph::create_simple_replacement compares signatures incorrectlySiblingSubgraph::from_node fails on nodes with disconnected outputs
Dec 11, 2024
Edited issue to focus on the fact that from_node doesn't work with disconnected outputs on the node because try_from_nodes doesn't. Making a separate issue for that: #1766
The function compares the signatures of the subgraph and replacement for equality:
hugr/hugr-core/src/hugr/views/sibling_subgraph.rs
Lines 384 to 385 in 4c1c6ee
However if the replacement had any disconnected outputs or multi-connected outputs this would fail because the current signature is calculated by iterating of the subgraph edges.
Disabling the signature check for the outputs is not enough because subsequent logic iterates over the subgraph outputs and misses out the disconnected port.
The text was updated successfully, but these errors were encountered: