Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename FunctionType::new_linear to new_endo #664

Closed
acl-cqc opened this issue Nov 8, 2023 · 4 comments · Fixed by #697
Closed

Rename FunctionType::new_linear to new_endo #664

acl-cqc opened this issue Nov 8, 2023 · 4 comments · Fixed by #697
Assignees

Comments

@acl-cqc
Copy link
Contributor

acl-cqc commented Nov 8, 2023

Linearity is a property of a value, not a function on that value. So, possibilities?

  • new_symmetric? (thanks to @seyon)
  • self_composable? But would have to be new_self_composable, too long.
  • Mathematically speaking, such functions are iterable - one can compute f^2, f^3 ... f^n. So new_iterable? But in a Rusty world, that sounds confusing
  • new_elidable? as in, we could just wire the inputs through to the outputs
  • new_identity_type? (It has the same type as the identity function, and/or, the signature is what you get by applying the identity function to the input types)
@cqc-alec
Copy link
Collaborator

cqc-alec commented Nov 9, 2023

I suggest new_endomorphic or new_endo for short ( https://en.wikipedia.org/wiki/Endomorphism ).

@ss2165
Copy link
Member

ss2165 commented Nov 9, 2023

FunctionType::new_endofunction?

edit: jinx!

@cqc-alec
Copy link
Collaborator

cqc-alec commented Nov 9, 2023

heh, almost snap

@acl-cqc
Copy link
Contributor Author

acl-cqc commented Nov 9, 2023

Yes I was thinking there was something from category theory and Endofunction/morphism is exactly it. I like new_endo (adding function on the end seems a bit redundant)...

@acl-cqc acl-cqc changed the title Rename FunctionType::new_linear...but, to what? Rename FunctionType::new_linear to new_endo Nov 12, 2023
@cqc-alec cqc-alec self-assigned this Nov 15, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 16, 2023
Closes #664 .

BREAKING_CHANGES: `FunctionType::new_linear()` renamed to
`FunctionType::new_endo()`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants