Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit both --all-features and --no-default--features coverage to codecov #799

Closed
aborgna-q opened this issue Jan 9, 2024 · 0 comments · Fixed by #851
Closed

Submit both --all-features and --no-default--features coverage to codecov #799

aborgna-q opened this issue Jan 9, 2024 · 0 comments · Fixed by #851
Assignees
Labels
ci CI / devops

Comments

@aborgna-q
Copy link
Collaborator

The extension_inference feature is experimental and may cause errors on otherwise correct code.
Hence we skip some tests when running with --all-features (see #795).
This means that those tests do not count for the coverage report sent to codecov.

To fix it we can submit both reports with/without extensions. Codecov then combines them into a single coverage metric.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci CI / devops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant