Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ci workflows to run on all pull_requests, rather than only those targeting main #972

Closed
doug-q opened this issue Apr 25, 2024 · 4 comments
Assignees

Comments

@doug-q
Copy link
Collaborator

doug-q commented Apr 25, 2024

No description provided.

@aborgna-q
Copy link
Collaborator

I don't see why not

@aborgna-q aborgna-q assigned aborgna-q and doug-q and unassigned aborgna-q Apr 25, 2024
@aborgna-q aborgna-q linked a pull request Apr 25, 2024 that will close this issue
@doug-q
Copy link
Collaborator Author

doug-q commented Apr 25, 2024

@seyon:
The automation aspect is a safety net - guarantee code reaching main has been checked
CI gets clogged if too many branches are active at once
when I am doingstacked PRs quite often I don't expect CI to pass further up the stack - I run the CI manually when I expect it to be ok to check

Of course we should not be wasteful with CI resources, although my view is still that we should make this change.

It is very easy to enable CI on the branch in the workflow in the branch itself(i.e. apply the patch in the linked PR), perhaps we should just do that as requrired.

@doug-q
Copy link
Collaborator Author

doug-q commented Apr 25, 2024

We have agreed to instead trigger on a (yet-to-be-specified) label. I suggest run-ci. Of course, triggering on all PRs targeting main will continue.

@doug-q
Copy link
Collaborator Author

doug-q commented Apr 26, 2024

After some investigation implementing this is non-trivial. It requires disjunctive logic which has to be done through if filters on each job. I do not think the value of this justifies the effort or ongoing maintenance, so I propose to drop this. One can apply the linked patch per-branch to activate CI.

@doug-q doug-q closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants