ci: run ci on all pull_requests #973
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add |
doug-q
force-pushed
the
ci/not-only-main
branch
from
484e541 to
875c282
Compare
aborgna-q
approved these changes
Apr 25, 2024
cqc-alec
approved these changes
Apr 25, 2024
| @@ -2,8 +2,6 @@ name: Check Conventional Commits format | |||
|
|
|||
| on: | |||
| pull_request_target: | |||
| branches: | |||
There was a problem hiding this comment.
Is this necessary? Not convinced, but if so, we should clarify what the conventions are for PRs to other branches -- e.g. are they supposed to signal fixes or breaking changes to the branch?
There was a problem hiding this comment.
This is a very good point. I agree that this, the most annoying of checks, should only apply to PRs targetting main while we are squash-merging.
|
Thanks @aborgna-q , I'm going to hold off on merging this until we have wider agreement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.