-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We have two struct ExtensionValue
#989
Comments
I suggest renaming |
what about |
Yeah either of those sounds OK to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
one in
hugr::ops::constant
, one inhugr::extension
.hugr::extension::ExtensionValue
describes a static value provided by andExtension
;hugr::ops::constant::ExtensionValue
is an opaqueBox<dyn CustomConst>
used in theValue::Extension
variant.I propose we rename one, although I don't have a good idea for how.
The text was updated successfully, but these errors were encountered: