Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump devenv.lock #1066

Merged
merged 1 commit into from
May 16, 2024
Merged

chore: bump devenv.lock #1066

merged 1 commit into from
May 16, 2024

Conversation

doug-q
Copy link
Collaborator

@doug-q doug-q commented May 16, 2024

This includes a bump to devenv that changes default behaviour to set up mold as the linker.

This includes a bump to devenv that changes default behaviour to set up
`mold` as the linker.
@doug-q doug-q requested a review from ss2165 May 16, 2024 10:58
@doug-q doug-q requested a review from a team as a code owner May 16, 2024 10:58
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

running time cargo test following cargo clean

Before:


Executed in 37.07 secs fish external
usr time 209.36 secs 121.00 micros 209.36 secs
sys time 14.57 secs 845.00 micros 14.57 secs

After:


Executed in 35.51 secs fish external
usr time 198.78 secs 0.11 millis 198.78 secs
sys time 13.61 secs 1.47 millis 13.60 secs

@doug-q
Copy link
Collaborator Author

doug-q commented May 16, 2024

That's not a fair test, this is:

#!/usr/bin/env sh

cargo test --no-run >&/dev/null
touch hugr/src/lib.rs
time cargo test --no-run

I see

  • ./bench.sh
real    0m2.272s
user    0m2.609s
sys     0m0.594s
  • RUSTFLAGS= ./bench.sh
real    0m6.743s
user    0m7.737s
sys     0m2.322s

@doug-q doug-q added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit cc7f067 May 16, 2024
13 checks passed
@doug-q doug-q deleted the doug/devenv-mold branch May 16, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants