refactor!: Rename builder helpers: ft1->endo_ft, ft2->inout_ft #1297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acl-cqc
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1297 +/- ##
=======================================
Coverage 87.18% 87.18%
=======================================
Files 107 107
Lines 19538 19538
Branches 17276 17276
=======================================
Hits 17034 17034
Misses 1719 1719
Partials 785 785
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closed
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 16, 2024
## 🤖 New release * `hugr`: 0.7.0 -> 0.8.0 * `hugr-core`: 0.4.0 -> 0.5.0 * `hugr-passes`: 0.4.0 -> 0.5.0 * `hugr-cli`: 0.1.3 -> 0.1.4 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.8.0 (2024-07-16) ### Bug Fixes - [**breaking**] Force_order failing on Const nodes, add arg to rank. ([#1300](#1300)) - NonConvex error on SiblingSubgraph::from_nodes with multiports ([#1295](#1295)) - [**breaking**] Ops require their own extension ([#1226](#1226)) ### Documentation - Attempt to correct force_order docs ([#1299](#1299)) ### Features - Make `DataflowOpTrait` public ([#1283](#1283)) - Make op members consistently public ([#1274](#1274)) ### Refactor - [**breaking**] Rename builder helpers: ft1->endo_ft, ft2->inout_ft ([#1297](#1297)) </blockquote> ## `hugr-core` <blockquote> ## 0.5.0 (2024-07-16) ### Bug Fixes - NonConvex error on SiblingSubgraph::from_nodes with multiports ([#1295](#1295)) - [**breaking**] Ops require their own extension ([#1226](#1226)) ### Features - Make `DataflowOpTrait` public ([#1283](#1283)) - Make op members consistently public ([#1274](#1274)) ### Refactor - [**breaking**] Rename builder helpers: ft1->endo_ft, ft2->inout_ft ([#1297](#1297)) </blockquote> ## `hugr-passes` <blockquote> ## 0.5.0 (2024-07-16) ### Bug Fixes - [**breaking**] Ops require their own extension ([#1226](#1226)) - [**breaking**] Force_order failing on Const nodes, add arg to rank. ([#1300](#1300)) ### Documentation - Attempt to correct force_order docs ([#1299](#1299)) ### Refactor - [**breaking**] Rename builder helpers: ft1->endo_ft, ft2->inout_ft ([#1297](#1297)) </blockquote> ## `hugr-cli` <blockquote> ## 0.1.3 (2024-07-10) ### Styling - Change "serialise" etc to "serialize" etc. ([#1251](#1251)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to this comment that "the builder...helpers are quite confusing", this offers a better compromise between brevity and readability, i.e. slightly more of the latter.
BREAKING CHANGE: builder::ft1 is now
builder::endo_ft, similarlyft2is newinout_ft