Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Print hugr-cli's errors on python tests #1310

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

aborgna-q
Copy link
Collaborator

Prints the error returned by hugr-cli when something fails, so we get better feedback.

Before:

subprocess.CalledProcessError: Command '['/Users/agustinborgna/src/hugr/target/debug/hugr', '-']' returned non-zero exit status 1.

After:

RuntimeError: Error validating HUGR: Parent node Node(0) has extensions [] that are too restrictive for child node Node(5), they must include child extensions [IdentList("quantum.tket2")]

@aborgna-q aborgna-q requested a review from cqc-alec July 16, 2024 10:37
@aborgna-q aborgna-q requested a review from a team as a code owner July 16, 2024 10:37
@aborgna-q aborgna-q enabled auto-merge July 16, 2024 10:39
Copy link

codecov bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.24%. Comparing base (cb84b84) to head (0d77777).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1310   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files         107      107           
  Lines       19586    19586           
  Branches    17322    17322           
=======================================
  Hits        17088    17088           
  Misses       1714     1714           
  Partials      784      784           
Flag Coverage Δ
python 91.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q aborgna-q added this pull request to the merge queue Jul 16, 2024
Merged via the queue into main with commit afe1a77 Jul 16, 2024
20 checks passed
@aborgna-q aborgna-q deleted the ab/print-hugr-cli-output branch July 16, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants