feat(hugr-passes): Add nonlocal_edges and ensure_no_nonlocal_edges
#1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1345 +/- ##
==========================================
+ Coverage 87.59% 87.65% +0.06%
==========================================
Files 112 113 +1
Lines 19964 20051 +87
Branches 17697 17784 +87
==========================================
+ Hits 17487 17576 +89
- Misses 1694 1695 +1
+ Partials 783 780 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ss2165
reviewed
Jul 25, 2024
hugr-passes/src/non_local.rs
Outdated
| //! This module provides functions for inspecting and modifying the nature of | ||
| //! non local edges in a Hugr. | ||
| //! | ||
| //! TODO Add `remove_nonlocal_edges` and `add_nonlocal_edges` functions |
There was a problem hiding this comment.
should this go in the module docstring or be left as a comment?
hugr-passes/src/non_local.rs
Outdated
|
|
||
| /// Returns an iterator over all non local edges in a Hugr. | ||
| /// | ||
| /// All `(node, in_port)` pairs are returned where `in_port` is connected to a |
There was a problem hiding this comment.
maybe make clear only checks value ports
hugr-passes/src/non_local.rs
Outdated
| hugr.nodes().flat_map(move |node| { | ||
| hugr.in_value_types(node).filter_map(move |(in_p, _)| { | ||
| hugr.linked_outputs(node, in_p) | ||
| .any(|(neighbour_node, _)| hugr.get_parent(node) != hugr.get_parent(neighbour_node)) |
There was a problem hiding this comment.
nit: hugr.get_parent(node) can be computed once outside this closure
hugr-passes/src/non_local.rs
Outdated
| let mut builder = DFGBuilder::new(Signature::new_endo(BOOL_T)).unwrap(); | ||
| let [in_w] = builder.input_wires_arr(); | ||
| let ([out_w], edge) = { | ||
| let mut builder = builder |
There was a problem hiding this comment.
nit: give this builder a different name to the outer one to make it easier to parse
There was a problem hiding this comment.
I prefer the same name. It is invalid to refer to the shadowed variable since the new one holds a mutable reference to it. But I do not feel strongly, have renamed.
Co-authored-by: Seyon Sivarajah <[email protected]>
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
## 🤖 New release * `hugr`: 0.9.1 -> 0.10.0 * `hugr-core`: 0.6.1 -> 0.7.0 * `hugr-passes`: 0.6.1 -> 0.6.2 * `hugr-cli`: 0.2.1 -> 0.3.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.10.0 (2024-07-26) ### Bug Fixes (#1350)) - [**breaking**] Bump serialisation version with no upgrade path ([#1352](#1352)) ### Features - Add `nonlocal_edges` and `ensure_no_nonlocal_edges` ([#1345](#1345)) - Serialization upgrade path ([#1327](#1327)) - [**breaking**] Replace opaque type arguments with String ([#1328](#1328)) - Add `impl Hash for Type` ([#1347](#1347)) - `HasDef` and `HasConcrete` traits for def/concrete op design pattern ([#1336](#1336)) - Add pointer standard extension ([#1337](#1337)) - [**breaking**] Remove the `Eq` type bound. ([#1364](#1364)) ### Refactor - [**breaking**] Use JSON rather than YAML in opaque fields. ([#1338](#1338)) - [**breaking**] Declarative module behind optional feature flag ([#1341](#1341)) ### Testing - Miri gate serialization upgrades ([#1349](#1349)) </blockquote> ## `hugr-core` <blockquote> ## 0.7.0 (2024-07-26) ### Bug Fixes (#1350)) - [**breaking**] Bump serialisation version with no upgrade path ([#1352](#1352)) ### Features - Serialization upgrade path ([#1327](#1327)) - [**breaking**] Replace opaque type arguments with String ([#1328](#1328)) - Add `impl Hash for Type` ([#1347](#1347)) - `HasDef` and `HasConcrete` traits for def/concrete op design pattern ([#1336](#1336)) - Add pointer standard extension ([#1337](#1337)) - [**breaking**] Remove the `Eq` type bound. ([#1364](#1364)) ### Refactor - [**breaking**] Use JSON rather than YAML in opaque fields. ([#1338](#1338)) - [**breaking**] Declarative module behind optional feature flag ([#1341](#1341)) ### Testing - Miri gate serialization upgrades ([#1349](#1349)) </blockquote> ## `hugr-passes` <blockquote> ## 0.6.2 (2024-07-26) ### Features - Add `nonlocal_edges` and `ensure_no_nonlocal_edges` ([#1345](#1345)) </blockquote> ## `hugr-cli` <blockquote> ## 0.3.0 (2024-07-26) ### Features - [**breaking**] Created `validate` CLI subcommand. ([#1312](#1312)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Douglas Wilson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1346