Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rs): hugr 0.9.1 patch release #1366

Merged
merged 3 commits into from
Jul 25, 2024
Merged

chore(rs): hugr 0.9.1 patch release #1366

merged 3 commits into from
Jul 25, 2024

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Jul 25, 2024

This is a patch release including only some non-breaking changes since 0.9.0.

New release

  • hugr: 0.9.0 -> 0.9.1
  • hugr-core: 0.6.0 -> 0.6.1
  • hugr-passes: 0.6.0 -> 0.6.1
  • hugr-cli: 0.2.0 -> 0.2.1
Changelog

hugr

0.9.1 (2024-07-25)

Bug Fixes

  • Dfg wrapper build handles incorrect output wire numbers (#1332)
  • Sibling extension panics while computing signature with non-dataflow nodes (#1350)

hugr-core

0.6.1 (2024-07-25)

Bug Fixes

  • Dfg wrapper build handles incorrect output wire numbers (#1332)
  • Sibling extension panics while computing signature with non-dataflow nodes (#1350)

hugr-passes

0.6.1 (2024-07-25)

Nothing here.

hugr-cli

0.2.1 (2024-07-25)

Nothing here.


This PR was generated by a human.

ss2165 and others added 3 commits July 25, 2024 16:06
DFGWrapper handles incorrectly were using internal dfg output number as
the outputs from the container node. Fixed for function, case and
tailloop. Also fixed a test that relied on this incorrect behaviour.

Closes #1257
…flow nodes (#1350)

The signature computation for a `SiblingSubgraph` takes the union of the
nodes' extensions. This didn't contemplate non-dataflow nodes like
constants, and caused a runtime panic if one was present.

Most of the diff is adding a constant node in the tests. 

This is a fix for CQCL/tket2#507
@aborgna-q aborgna-q requested review from cqc-alec, ss2165 and a team as code owners July 25, 2024 15:10
@aborgna-q aborgna-q enabled auto-merge July 25, 2024 15:14
@aborgna-q aborgna-q disabled auto-merge July 25, 2024 15:14
Copy link

codecov bot commented Jul 25, 2024

Codecov Report

Attention: Patch coverage is 92.45283% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.66%. Comparing base (ed5876c) to head (32a333e).
Report is 16 commits behind head on main.

Files Patch % Lines
hugr-core/src/hugr/validate/test.rs 33.33% 0 Missing and 2 partials ⚠️
hugr-core/src/builder/tail_loop.rs 80.00% 0 Missing and 1 partial ⚠️
hugr-core/src/hugr/views/sibling_subgraph.rs 97.67% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
+ Coverage   87.44%   87.66%   +0.21%     
==========================================
  Files         108      113       +5     
  Lines       19790    20051     +261     
  Branches    17527    17784     +257     
==========================================
+ Hits        17306    17577     +271     
+ Misses       1718     1694      -24     
- Partials      766      780      +14     
Flag Coverage Δ
python 91.53% <ø> (+0.10%) ⬆️
rust 87.16% <92.45%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q aborgna-q enabled auto-merge July 25, 2024 15:33
@aborgna-q aborgna-q added this pull request to the merge queue Jul 25, 2024
Merged via the queue into main with commit 58853d3 Jul 25, 2024
28 checks passed
@aborgna-q aborgna-q deleted the ab/hugr-0.9.1 branch July 25, 2024 15:35
ss2165 added a commit that referenced this pull request Jul 26, 2024
This is a patch release including only some non-breaking changes since
0.9.0.

## New release
* `hugr`: 0.9.0 -> 0.9.1
* `hugr-core`: 0.6.0 -> 0.6.1
* `hugr-passes`: 0.6.0 -> 0.6.1
* `hugr-cli`: 0.2.0 -> 0.2.1

<details><summary><i><b>Changelog</b></i></summary><p>

## `hugr`
<blockquote>

## 0.9.1 (2024-07-25)

### Bug Fixes

- Dfg wrapper build handles incorrect output wire numbers
([#1332](#1332))
- Sibling extension panics while computing signature with non-dataflow
nodes ([#1350](#1350))
</blockquote>

## `hugr-core`
<blockquote>

## 0.6.1 (2024-07-25)

### Bug Fixes

- Dfg wrapper build handles incorrect output wire numbers
([#1332](#1332))
- Sibling extension panics while computing signature with non-dataflow
nodes ([#1350](#1350))
</blockquote>

## `hugr-passes`
<blockquote>

## 0.6.1 (2024-07-25)

Nothing here.
</blockquote>

## `hugr-cli`
<blockquote>

## 0.2.1 (2024-07-25)

Nothing here.
</blockquote>


</p></details>

---
This PR was generated by a human.

---------

Co-authored-by: Seyon Sivarajah <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants