feat: Add Eq op to logic extension #1398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1398 +/- ##
==========================================
- Coverage 87.64% 87.63% -0.01%
==========================================
Files 118 118
Lines 20347 20352 +5
Branches 18035 18040 +5
==========================================
+ Hits 17833 17836 +3
Misses 1725 1725
- Partials 789 791 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
acl-cqc
reviewed
Aug 8, 2024
| @@ -331,6 +340,8 @@ pub(crate) mod test { | |||
| #[case(NaryLogic::Or, [], false)] | |||
| #[case(NaryLogic::Or, [false, false, true], true)] | |||
| #[case(NaryLogic::Or, [false, false, false], false)] | |||
| #[case(NaryLogic::Eq, [true, true, false, true], false)] | |||
| #[case(NaryLogic::Eq, [false, false], true)] | |||
There was a problem hiding this comment.
Add some couple of cases to nary_partial_const_fold too?
Co-authored-by: Alan Lawrence <[email protected]>
Co-authored-by: Alan Lawrence <[email protected]>
acl-cqc
approved these changes
Aug 8, 2024
| @@ -355,6 +366,9 @@ pub(crate) mod test { | |||
| #[case(NaryLogic::And, [Some(false), None], Some(false))] | |||
| #[case(NaryLogic::Or, [None, Some(false)], None)] | |||
| #[case(NaryLogic::Or, [None, Some(true)], Some(true))] | |||
| #[case(NaryLogic::Eq, [None, Some(true), Some(true)], None)] | |||
| #[case(NaryLogic::Eq, [None, Some(false), Some(true)], Some(false))] | |||
| #[case(NaryLogic::Eq, [Some(true), Some(true), Some(true)], Some(true))] | |||
There was a problem hiding this comment.
nit: the last doesn't need to be expressed in the more-complex nary_partial_const_fold format, right? Doing so is a test of the test framework, rather than the code-under-test! You could move it to nary_const_fold or remove it.
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
## 🤖 New release * `hugr`: 0.10.0 -> 0.11.0 * `hugr-core`: 0.7.0 -> 0.8.0 * `hugr-passes`: 0.6.2 -> 0.7.0 * `hugr-cli`: 0.3.0 -> 0.4.0 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## 0.11.0 (2024-08-12) ### Bug Fixes - [**breaking**] BasicBlockExits should not be `OpTag::DataflowParent` ([#1409](#1409)) ### Documentation - Clarify CustomConst::equal_consts ([#1396](#1396)) ### Features - [**breaking**] Serialised extensions ([#1371](#1371)) - Serialised standard extensions ([#1377](#1377)) - [**breaking**] Update remaining builder methods to "infer by default" ([#1386](#1386)) - Add Eq op to logic extension ([#1398](#1398)) - Improve error message on failed custom op validation ([#1416](#1416)) - [**breaking**] `Extension` requires a version ([#1367](#1367)) </blockquote> ## `hugr-core` <blockquote> ## 0.8.0 (2024-08-12) ### Bug Fixes - [**breaking**] BasicBlockExits should not be `OpTag::DataflowParent` ([#1409](#1409)) ### Documentation - Clarify CustomConst::equal_consts ([#1396](#1396)) ### Features - [**breaking**] `Extension` requires a version ([#1367](#1367)) - [**breaking**] Serialised extensions ([#1371](#1371)) - Serialised standard extensions ([#1377](#1377)) - [**breaking**] Update remaining builder methods to "infer by default" ([#1386](#1386)) - Add Eq op to logic extension ([#1398](#1398)) - Improve error message on failed custom op validation ([#1416](#1416)) </blockquote> ## `hugr-passes` <blockquote> ## 0.7.0 (2024-08-12) ### Features - [**breaking**] `Extension` requires a version ([#1367](#1367)) </blockquote> ## `hugr-cli` <blockquote> ## 0.4.0 (2024-08-12) ### Features - Serialised standard extensions ([#1377](#1377)) - Validate with extra extensions and packages ([#1389](#1389)) - [**breaking**] Move mermaid to own sub-command ([#1390](#1390)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). --------- Co-authored-by: Craig Roy <[email protected]>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.