fix: Equality check between Sum types
#1422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croyzor
approved these changes
Aug 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1422 +/- ##
==========================================
+ Coverage 87.69% 87.70% +0.01%
==========================================
Files 118 118
Lines 20441 20443 +2
Branches 18045 18045
==========================================
+ Hits 17926 17930 +4
+ Misses 1727 1725 -2
Partials 788 788
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 14, 2024
🤖 I have created a release *beep* *boop* --- ## [0.7.0](hugr-py-v0.6.0...hugr-py-v0.7.0) (2024-08-14) ### ⚠ BREAKING CHANGES * **hugr-py:** `AsCustomOp` replaced with `AsExtOp`, so all such operations now need to be attached to an extension. ### Features * **hugr-py:** user facing Extension class ([#1413](#1413)) ([c6473c9](c6473c9)) * **py:** Add node metadata ([#1428](#1428)) ([b229be6](b229be6)), closes [#1319](#1319) ### Bug Fixes * Equality check between `Sum` types ([#1422](#1422)) ([8dfea09](8dfea09)) * **py:** Invalid serialization of float and int constants ([#1427](#1427)) ([b89c08f](b89c08f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sum,TupleandUnitSumcan represent the same type, but the equality fn checked the specific subclasses.