Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use local ruff and mypy for pre-commit #1440

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

aborgna-q
Copy link
Collaborator

Ensures that the checks run by pre-commit are the same as the ones run in CI.
Before, we used pre-commit actions with their own versions that needed to be updated separately and tended to get out of date.

As an example, the ruff update errors from #1437 didn't appear locally when running just check.

drive-by: Update ruff to latest version

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.55%. Comparing base (3a7d09f) to head (561c72b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1440   +/-   ##
=======================================
  Coverage   87.55%   87.55%           
=======================================
  Files         119      119           
  Lines       20781    20781           
  Branches    18053    18053           
=======================================
  Hits        18194    18194           
  Misses       1802     1802           
  Partials      785      785           
Flag Coverage Δ
python 90.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q aborgna-q added this pull request to the merge queue Aug 16, 2024
Merged via the queue into main with commit 0689868 Aug 16, 2024
21 checks passed
@aborgna-q aborgna-q deleted the ab/local-precommit-ruff-mypy branch August 16, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants