Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Bundle crates under the same version_group #1572

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

aborgna-q
Copy link
Collaborator

This should solve the diamond problem we had where hugr-core get's a breaking release but hugr-passes only publishes a minor, so cargo automatically updates the latter and we get diverging hugr-core versions on the dependency tree (so the public APIs break).

version_group defines a grouping of versions, where packages that had changes will all be bumped to the same version.
https://release-plz.ieni.dev/docs/config#the-version_group-field

In the previous example, a mayor bump to hugr-core will cause a mayor release for both hugr-passes and hugr.
On the other hand, a change to hugr-passes will not trigger a bump on hugr-core.

An alternative (non-automated) solution to this problem can be done via the semver-trick [0,1], but that's a one-off manual solution more useful to avoid problems for external libraries.

@aborgna-q aborgna-q requested a review from a team as a code owner October 11, 2024 10:29
@aborgna-q aborgna-q requested review from zrho and doug-q and removed request for a team October 11, 2024 10:29
Base automatically changed from ab/release-plz-cliff to main October 11, 2024 10:37
Copy link
Contributor

@zrho zrho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense.

@aborgna-q aborgna-q added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 4f0e272 Oct 11, 2024
16 checks passed
@aborgna-q aborgna-q deleted the ab/release-version-groups branch October 11, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants