ci: Run cargo-semver-checks on PRs #1598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1598 +/- ##
=======================================
Coverage 85.72% 85.72%
=======================================
Files 136 136
Lines 24783 24783
Branches 21719 21719
=======================================
Hits 21244 21244
Misses 2437 2437
Partials 1102 1102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aborgna-q
force-pushed
the
ab/ci-semver-checks
branch
4 times, most recently
from
505bfc9 to
4cc0f10
Compare
aborgna-q
force-pushed
the
ab/ci-semver-checks
branch
3 times, most recently
from
d482fa9 to
f7683d7
Compare
aborgna-q
force-pushed
the
ab/ci-semver-checks
branch
from
f7683d7 to
d573bf2
Compare
aborgna-q
commented
Oct 18, 2024
.github/workflows/ci-rs.yml
Outdated
| rs-semver-checks: | ||
| needs: changes | ||
| if: ${{ needs.changes.outputs.rust == 'true' && github.event_name == 'pull_request' }} | ||
| uses: CQCL/hugrverse-actions/.github/workflows/rs-semver-checks.yml@ab/semver-checks |
There was a problem hiding this comment.
I'll change the target branch as soon as CQCL/hugrverse-actions#13 is merged
ss2165
approved these changes
Oct 21, 2024
.github/workflows/ci-rs.yml
Outdated
| id: override | ||
| run: | | ||
| echo "Labels: ${{ github.event.pull_request.labels.*.name }}" | ||
| echo "Label contains run-ci-checks: ${{ contains( github.event.pull_request.labels.*.name, 'run-ci-checks') }}" |
There was a problem hiding this comment.
seems worth writing the result of contains( to a var
aborgna-q
added
the
run-ci-checks
aborgna-q
force-pushed
the
ab/ci-semver-checks
branch
from
b0c3ffe to
638f3a5
Compare
github-merge-queue bot
pushed a commit
to CQCL/hugrverse-actions
that referenced
this pull request
Oct 21, 2024
Test PR: CQCL/hugr#1598 Limitations: - Comments won't be updated when the PR title is changed (added/removed a `!` flag). It will only change when a new commit is pushed.
ss2165
pushed a commit
that referenced
this pull request
Nov 22, 2024
Run `cargo-ci-checks` on each PR, and add a comment with the output if there are breaking changes. See CQCL/hugrverse-actions#13 drive-by: Allow forcing the checks to run by adding a `run-ci-checks` label to the PR. Imported from tket2. https://github.com/CQCL/tket2/blob/740b3ec20f7d3889162c935a47cd0de9ba250a45/.github/workflows/ci.yml#L44 <img width="894" alt="image" src="https://github.com/user-attachments/assets/10748599-e2ab-46fa-979f-d8246c203d5a">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run
cargo-ci-checkson each PR, and add a comment with the output if there are breaking changes.See CQCL/hugrverse-actions#13
drive-by: Allow forcing the checks to run by adding a
run-ci-checkslabel to the PR. Imported from tket2.https://github.com/CQCL/tket2/blob/740b3ec20f7d3889162c935a47cd0de9ba250a45/.github/workflows/ci.yml#L44