Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix unused warnings on default features #1618

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

Fixes two unused import errors that only appeared when ignoring some features.
We test cargo clippy --all-features on CI, so this didn't get flagged.

warning: unused import: `poly_func::PolyFuncTypeBase`
  --> hugr-core/src/types.rs:19:16
   |
19 | pub(crate) use poly_func::PolyFuncTypeBase;
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `signature::FuncTypeBase`
  --> hugr-core/src/types.rs:21:16
   |
21 | pub(crate) use signature::FuncTypeBase;
   |                ^^^

@aborgna-q aborgna-q requested a review from a team as a code owner October 29, 2024 10:41
@aborgna-q aborgna-q requested a review from cqc-alec October 29, 2024 10:41
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.62%. Comparing base (87150fa) to head (ff60b97).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1618   +/-   ##
=======================================
  Coverage   85.62%   85.62%           
=======================================
  Files         136      136           
  Lines       24928    24929    +1     
  Branches    21854    21855    +1     
=======================================
+ Hits        21344    21346    +2     
  Misses       2476     2476           
+ Partials     1108     1107    -1     
Flag Coverage Δ
python 92.45% <ø> (ø)
rust 84.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aborgna-q aborgna-q added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit fed74b5 Oct 29, 2024
22 checks passed
@aborgna-q aborgna-q deleted the ab/unused-warnings branch October 29, 2024 10:55
ss2165 pushed a commit that referenced this pull request Nov 22, 2024
Fixes two unused import errors that only appeared when ignoring some
features.
We test `cargo clippy --all-features` on CI, so this didn't get flagged.

```
warning: unused import: `poly_func::PolyFuncTypeBase`
  --> hugr-core/src/types.rs:19:16
   |
19 | pub(crate) use poly_func::PolyFuncTypeBase;
   |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

warning: unused import: `signature::FuncTypeBase`
  --> hugr-core/src/types.rs:21:16
   |
21 | pub(crate) use signature::FuncTypeBase;
   |                ^^^
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants