feat: Lower array repeat and scan ops #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
croyzor
reviewed
Dec 5, 2024
| /// the array. I.e. it is of type `array.get_element_type().ptr_type()` not | ||
| /// `array.ptr_type()` | ||
| fn with_array_alloca<'c, T, E: From<BuilderError>>( | ||
| /// Returns two pointers: The first one |
There was a problem hiding this comment.
This comment looks unfinished
croyzor
reviewed
Dec 9, 2024
| #[case(5, 42, 2)] | ||
| #[case(5, 42, 3)] | ||
| #[case(5, 42, 4)] | ||
| fn exec_repeat( |
There was a problem hiding this comment.
This isn't a very satisfying test -- it'd be nicer to have something where the function inspects the inputs and puts a different value in each location
There was a problem hiding this comment.
That's not possible with repeat, all values in the array must have the same value
There was a problem hiding this comment.
Ah I see, I was thinking repeat was haskell's Data.List.iterate
| // We build a HUGR that: | ||
| // - Creates an array [1, 2, 3, ..., size] | ||
| // - Maps a function that increments each element by `inc` | ||
| // - Returns the sum of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1681