feat: Do not require capnp to be installed to compile hugr-model
#1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1907 +/- ##
==========================================
- Coverage 86.70% 83.77% -2.93%
==========================================
Files 195 196 +1
Lines 35538 37380 +1842
Branches 32351 34193 +1842
==========================================
+ Hits 30814 31316 +502
- Misses 2951 4287 +1336
- Partials 1773 1777 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I tried to merge this without rebasing #1893 and the merge queue check failed due to not updating the generated artifact :) |
aborgna-q
force-pushed
the
ab/offline-capnp
branch
from
415975a to
f80788d
Compare
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
Alternative to #1908 I was a bit too eager when removing `capnp` in #1907. https://github.com/CQCL/hugr/pull/1907/files#diff-8c3de78a6f07b22f56457fe701ccc74e767b3e22be85276c500eb1a81c01281eL46-L47
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
## 🤖 New release * `hugr`: 0.14.3 * `hugr-core`: 0.14.3 * `hugr-model`: 0.17.1 * `hugr-llvm`: 0.14.3 * `hugr-passes`: 0.14.3 * `hugr-cli`: 0.14.3 <details><summary><i><b>Changelog</b></i></summary><p> ## `hugr` <blockquote> ## [0.14.3](hugr-v0.14.2...hugr-v0.14.3) - 2025-02-05 ### Bug Fixes - Export `RemoveDeadFuncsError` (#1883) - const-folding Module keeps at least "main" (#1901) - determine correct bounds of custom types (#1888) - Exporting converging control flow edges (#1890) ### Documentation - Fix deprecation warning messages (#1891) - Explain why `ConstF64` is not PartialEq (#1829) ### New Features - Special cased array, float and int constants in hugr-model export (#1857) - Simplify hugr-model (#1893) </blockquote> ## `hugr-core` <blockquote> ## [0.14.3](hugr-core-v0.14.2...hugr-core-v0.14.3) - 2025-02-05 ### Bug Fixes - determine correct bounds of custom types (#1888) - Exporting converging control flow edges (#1890) ### Documentation - Explain why `ConstF64` is not PartialEq (#1829) ### New Features - Special cased array, float and int constants in hugr-model export (#1857) - Simplify hugr-model (#1893) </blockquote> ## `hugr-model` <blockquote> ## [0.17.1](hugr-model-v0.17.0...hugr-model-v0.17.1) - 2025-02-05 ### Bug Fixes - determine correct bounds of custom types (#1888) ### New Features - Special cased array, float and int constants in hugr-model export (#1857) - Simplify hugr-model (#1893) - Do not require `capnp` to be installed to compile `hugr-model` (#1907) </blockquote> ## `hugr-llvm` <blockquote> ## [0.14.2](hugr-llvm-v0.14.1...hugr-llvm-v0.14.2) - 2025-01-20 ### New Features - *(hugr-llvm)* Emit more int ops (#1835) - Constant values in `hugr-model` (#1838) - *(hugr-llvm)* Emit ipow (#1839) ### Refactor - *(hugr-llvm)* [**breaking**] Optimise the llvm types used to represent hugr sums. (#1855) ### Testing - Fix failing inot test (#1841) </blockquote> ## `hugr-passes` <blockquote> ## [0.14.3](hugr-passes-v0.14.2...hugr-passes-v0.14.3) - 2025-02-05 ### Bug Fixes - Export `RemoveDeadFuncsError` (#1883) - const-folding Module keeps at least "main" (#1901) ### Documentation - Fix deprecation warning messages (#1891) </blockquote> ## `hugr-cli` <blockquote> ## [0.14.1](hugr-cli-v0.14.0...hugr-cli-v0.14.1) - 2024-12-18 ### New Features - Print `hugr-cli`'s correct version when using '--version' (#1790) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we do the same as with the schema and extensions definition; provide a
justcommand to update it manually and check on CI that things are up-to-date.This lets us remove the
build.rsfromhugr-model, removing the need for users to havecapnprotoinstalled to compile our crates.Closes #1667