chore: turn off extension inference testing #796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
changed the title
aborgna-q
reviewed
Jan 9, 2024
There was a problem hiding this comment.
It's a bit annoying having failing tests in HEAD.
Perhaps we could conditionally #[ignore] them instead?
We'd then be able to run the tests with
cargo test -- --include-ignoredwhen needed.
If we keep this PR as-is, make sure to remove the --all-features flags from .github/pre-commit too.
Comment on lines
+87
to
+88
| # - name: Tests with all features | ||
| # run: cargo test --verbose --all-features |
There was a problem hiding this comment.
Replace this with a note about why we don't run the tests
Suggested change
| # - name: Tests with all features | |
| # run: cargo test --verbose --all-features | |
| # Note: The `extension_inference` feature is experimental, we don't expect tests to succeed. |
| @@ -102,9 +102,9 @@ jobs: | |||
| - name: Run tests with coverage instrumentation | |||
| run: | | |||
| cargo llvm-cov clean --workspace | |||
| cargo llvm-cov --all-features --doctests | |||
| cargo llvm-cov --doctests | |||
There was a problem hiding this comment.
This will bring the coverage down by a large margin.
It may be nice to spread
#![cfg_attr(coverage, feature(no_coverage))]around.
(Note: That'll make llvm-cov run only on nightly, but that should be ok).
|
Closing in favour of skipping failing inference tests: ac78815 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.