-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add example to CFGBuilder
#826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss2165
requested changes
Feb 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good comprehensive example
01f5dc7
to
684c7de
Compare
ss2165
approved these changes
Feb 20, 2024
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 20, 2024
## 🤖 New release * `quantinuum-hugr`: 0.1.0 -> 0.2.0 (⚠️ API breaking changes) ###⚠️ `quantinuum-hugr` breaking changes ``` --- failure method_parameter_count_changed: pub method parameter count changed --- Description: A publicly-visible method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/method_parameter_count_changed.ron Failed in: hugr::std_extensions::collections::ListValue::new now takes 2 parameters instead of 1, in /tmp/.tmpL6EHPb/hugr/src/std_extensions/collections.rs:40 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/trait_method_missing.ron Failed in: method check_custom_type of trait CustomConst, previously in file /tmp/.tmpEGb5eE/quantinuum-hugr/src/values.rs:157 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.28.0/src/lints/trait_missing.ron Failed in: trait hugr::values::KnownTypeConst, previously in file /tmp/.tmpEGb5eE/quantinuum-hugr/src/values.rs:180 ``` <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## 0.2.0 (2024-02-20) ### Documentation - Fix crates.io badge in README ([#809](#809)) - Use absolute links in the README ([#811](#811)) - Remove input->const order edges from spec diagrams ([#812](#812)) - Remove incorrect indentation in spec ([#813](#813)) - Tweaks to main example ([#825](#825)) - Add example to `CFGBuilder` ([#826](#826)) ### Features - Add InlineDFG rewrite ([#828](#828)) - [**breaking**] Impls of CustomConst must be able to report their type ([#827](#827)) - Minimal implementation for YAML extensions ([#833](#833)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.