-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add crate::algorithm::iter #830
Conversation
4ad2cb6
to
fb26620
Compare
8073d03
to
e454dab
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #830 +/- ##
==========================================
+ Coverage 84.12% 84.18% +0.05%
==========================================
Files 73 74 +1
Lines 13920 13996 +76
Branches 13920 13996 +76
==========================================
+ Hits 11710 11782 +72
+ Misses 1422 1418 -4
- Partials 788 796 +8 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Really like the petgraph use
- A test of controlflow would be good since that has an alternative logic path
- Should these functions be impls on
SiblingGraph
orHugrView
?
@@ -0,0 +1,244 @@ | |||
//! Routines for iterating over all nodes in a Hugr, attending to visiting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"attending to visiting"? worth rewording
h.hugr_mut() | ||
.move_before_sibling(dfg.handle().node(), noop.handle().node())?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this testing that hierarchy sibiling order doesn't matter? worth a comment
I think it is reasonable to consider adding It is unclear whether those functions should take a node, or perhaps multiple variants should be added, with and without the node. The name My view is that we should not add them at this time, until we are more certain. I will add comments to this effect, lmk if you disagree. |
Co-authored-by: Seyon Sivarajah <[email protected]>
Co-authored-by: Seyon Sivarajah <[email protected]>
Co-authored-by: Seyon Sivarajah <[email protected]>
Co-authored-by: Seyon Sivarajah <[email protected]>
Co-authored-by: Seyon Sivarajah <[email protected]>
No description provided.