Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add builder module docs + example #853

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Conversation

aborgna-q
Copy link
Collaborator

drive-by: Make the CircuitBuilder constructor a bit more generic.

@aborgna-q aborgna-q requested a review from cqc-alec March 1, 2024 14:51
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (197541b) to head (1c33f2d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #853   +/-   ##
=======================================
  Coverage   84.00%   84.00%           
=======================================
  Files          77       77           
  Lines       14230    14233    +3     
  Branches    14230    14233    +3     
=======================================
+ Hits        11954    11957    +3     
  Misses       1440     1440           
  Partials      836      836           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some suggestions on capitalization and punctuation, looks good.

@aborgna-q aborgna-q added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 065f675 Mar 1, 2024
10 checks passed
@aborgna-q aborgna-q deleted the docs/builder-examples branch March 1, 2024 16:28
@github-actions github-actions bot mentioned this pull request Mar 1, 2024
@github-actions github-actions bot mentioned this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants