chore: Add a rust workspace #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborgna-q
force-pushed
the
refactor/workspace
branch
from
44ee5cd to
6608d4c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
- Coverage 84.25% 84.21% -0.05%
==========================================
Files 78 78
Lines 14283 14283
Branches 14283 14283
==========================================
- Hits 12034 12028 -6
- Misses 1414 1420 +6
Partials 835 835 ☔ View full report in Codecov by Sentry. |
croyzor
reviewed
Mar 7, 2024
| @@ -135,7 +135,6 @@ | |||
| //! ``` | |||
| //! | |||
|
|
|||
| #![warn(missing_docs)] | |||
There was a problem hiding this comment.
Now it's on the workspace Cargo.toml (under [workspace.lints.rust]).
croyzor
approved these changes
Mar 7, 2024
This was referenced Mar 8, 2024
Closed
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
#868 didn't actually enable the lints in `quantinuum-hugr` when the config was moved to the workspace.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the main crate to a directory.
This change does not alter the public package.
Closes #865