ci: Skip invalid miri test, avoid concurrent undsoundness checks #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests used `insta`, and miri doesn't like filesystems
The tests take ~15mins, so this prevents hogging the workers.
cqc-alec
approved these changes
Mar 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #870 +/- ##
==========================================
+ Coverage 84.14% 84.21% +0.07%
==========================================
Files 78 78
Lines 14283 14283
Branches 14283 14283
==========================================
+ Hits 12018 12028 +10
+ Misses 1429 1420 -9
+ Partials 836 835 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the failing unsoundness check in
mainhttps://github.com/CQCL/hugr/actions/runs/8158956607/job/22302072598
The test change in feat: Mermaid renderer for hugrs #852 moved the miri ignore flag, and it seems it has to be placed after
rstest's cases.Adds a concurrency group for the unsoundness check.
The check currently takes around 15mins (and it will only grow as we add more tests).
This makes it so old jobs get cancelled when pushing new changes to main, and a new check is started.