-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Make some Container
methods infallible
#872
Conversation
Updated methods that could only return `Err` on internal bugs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #872 +/- ##
==========================================
+ Coverage 85.32% 85.66% +0.33%
==========================================
Files 78 78
Lines 14403 14408 +5
Branches 14403 14408 +5
==========================================
+ Hits 12290 12342 +52
+ Misses 1431 1427 -4
+ Partials 682 639 -43 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some stray unfinished comments that should be deleted. Otherwise, LGTM.
Co-authored-by: Kartik Singhal <[email protected]>
Updated methods that could only return
Err
on internal bugs.This is a followup to #869, doing some more cleaning on the
build_traits::Container
interface.Changes outside
build_traits.rs
are just fixing the call sites.BREAKING CHANGE: Multiple methods in
Container
no longer return aResult