Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rs-semver-checks should check if the crate builds before running semver-checks #29

Closed
aborgna-q opened this issue Dec 2, 2024 · 0 comments · Fixed by #30
Closed

rs-semver-checks should check if the crate builds before running semver-checks #29

aborgna-q opened this issue Dec 2, 2024 · 0 comments · Fixed by #30
Assignees
@aborgna-q

Comments

@aborgna-q
Copy link
Collaborator

If the check fails because the crate doesn't build, we currently post a comment with empty diagnostics.
We should instead do a cargo check first, and abort if that fails.
@aborgna-q aborgna-q mentioned this issue Dec 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 2, 2024
@aborgna-q
feat(rs-semver-checks): Early fail if the crate has build errors (#30)
3ce20b7 
Closes #29 

drive-by: Use the right "head commit" when running in a
`pull_request_target` event. Otherwise we where fetching the base ref,
and not detecting anything. See [this
run](https://github.com/CQCL/hugr/actions/runs/12118219519/job/33782281012?pr=1723#step:2:72),
where both HEAD and BASE checkouts use the same sha.
@aborgna-q aborgna-q self-assigned this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(rs-semver-checks): Early fail if the crate has build errors CQCL/hugrverse-actions
1 participant
@aborgna-q