Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add a slack notifier workflow #18

Merged
merged 5 commits into from
Oct 25, 2024
Merged

ci: Add a slack notifier workflow #18

merged 5 commits into from
Oct 25, 2024

Conversation

aborgna-q
Copy link
Collaborator

Add a workflow based on slackapi/slack-github-action, that lets us rate-limit messages sent to slack to avoid spamming.

@aborgna-q aborgna-q requested a review from a team as a code owner October 25, 2024 09:44
@aborgna-q aborgna-q requested review from croyzor and removed request for a team October 25, 2024 09:44
Base automatically changed from ab/coverage-trend to main October 25, 2024 10:12
@aborgna-q
Copy link
Collaborator Author

@aborgna-q aborgna-q marked this pull request as draft October 25, 2024 11:53
@aborgna-q
Copy link
Collaborator Author

Marking as draft until I solve how to keep track of timeouts.
The current "file artifact" solution only works if this workflow is called on each parent workflow run.
Otherwise, download-artifacts will not find any files in the previous run so the rate limiting would be ignored.

@aborgna-q aborgna-q force-pushed the ab/slack-notifier branch 7 times, most recently from f303e4e to 8e4d3eb Compare October 25, 2024 14:56
@aborgna-q
Copy link
Collaborator Author

@aborgna-q aborgna-q requested review from cqc-alec and removed request for croyzor October 25, 2024 15:08
@aborgna-q aborgna-q marked this pull request as ready for review October 25, 2024 15:08
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aborgna-q aborgna-q added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit 8279ce0 Oct 25, 2024
1 check passed
@aborgna-q aborgna-q deleted the ab/slack-notifier branch October 25, 2024 15:49
github-merge-queue bot pushed a commit to CQCL/hugr that referenced this pull request Oct 25, 2024
Using the new notify-slack workflow from
CQCL/hugrverse-actions#18.
I'll update the target branch once that is merged.
github-merge-queue bot pushed a commit to CQCL/tket-json-rs that referenced this pull request Oct 25, 2024
Updates the missing ops slack notifier to run daily, so we find the
errors quicker.
We use the new workflow from
CQCL/hugrverse-actions#18 to add a one-week
timeout, so we don't spam the chat.

The notification step was actually broken on `main`. This PR adds a
`continue-on-error` flag on the test job so it doesn't get skipped the
notification when it fails.
ss2165 pushed a commit to CQCL/hugr that referenced this pull request Nov 22, 2024
Using the new notify-slack workflow from
CQCL/hugrverse-actions#18.
I'll update the target branch once that is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants