Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tket1 conversion of measure is broken #330

Closed
ss2165 opened this issue May 2, 2024 · 0 comments · Fixed by #331
Closed

fix: tket1 conversion of measure is broken #330

ss2165 opened this issue May 2, 2024 · 0 comments · Fixed by #331
Assignees
@aborgna-q

Comments

@ss2165
Copy link
Member

ss2165 commented May 2, 2024

Currently tket2->tket1 measure matches the op and then breaks because the signatures don't match (tket2 op does not take in a linear bit)

Tket1->tket2 just encodes it opaquely (doesn't map to Tk2Op::Measure)

I think the "fix" is just to remove the match in the tket2->tket1 direction
@aborgna-q aborgna-q self-assigned this May 2, 2024
@aborgna-q aborgna-q mentioned this issue May 2, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 2, 2024
@aborgna-q
fix: Don't convert tket2 measurements into tket1 ops (#331)
2f1d1a1 
Throws an error instead of converting the operation into one with
different signature.

Fixes #330
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aborgna-q aborgna-q

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Don't convert tket2 measurements into tket1 ops CQCL/tket2
2 participants
@ss2165 @aborgna-q