fix: Use RemoveDeadFuncsPass instead of deprecated remove_polyfuncs()
#759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
changed the title
RemoveDeadFuncsPass instead of deprecated remove_polyfuncs()RemoveDeadFuncsPass instead of deprecated remove_polyfuncs()
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #759 +/- ##
=======================================
Coverage 82.31% 82.31%
=======================================
Files 63 63
Lines 7740 7742 +2
Branches 7484 7486 +2
=======================================
+ Hits 6371 6373 +2
Misses 979 979
Partials 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cqc-alec
requested review from
lmondada and
acl-cqc
and removed request for
lmondada
aborgna-q
reviewed
Jan 27, 2025
uv.lock
Outdated
There was a problem hiding this comment.
Outdated uv ? Try uv self update.
tket2-hseries/Cargo.toml
Outdated
| @@ -23,6 +23,7 @@ required-features = ["cli"] | |||
|
|
|||
| [dependencies] | |||
| hugr.workspace = true | |||
| hugr-passes = "0.14.2" | |||
There was a problem hiding this comment.
-
Dependencies should go on the workspace's
Cargo.toml, and.workspace = true'd here. -
We are currently at
hugr 0.14.1on the workspace file, we should use the same versions all around.
| @@ -80,7 +81,7 @@ impl QSystemPass { | |||
| self.validation_level.run_validated_pass(hugr, |hugr, _| { | |||
| let mut owned_hugr = Hugr::default(); | |||
| mem::swap(&mut owned_hugr, hugr); | |||
| owned_hugr = remove_polyfuncs(owned_hugr); | |||
| RemoveDeadFuncsPass::default().run(&mut owned_hugr).unwrap(); | |||
There was a problem hiding this comment.
The unwrap here is annoying, but returning the error requires a release with CQCL/hugr#1883.
We should have a TODO here linking to that PR.
#753 should fix it later.
aborgna-q
approved these changes
Jan 27, 2025
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 12, 2025
## 🤖 New release * `tket2`: 0.7.1 -> 0.7.2 (✓ API compatible changes) * `tket2-hseries`: 0.8.0 -> 0.9.0 (✓ API compatible changes) <details><summary><i><b>Changelog</b></i></summary><p> ## `tket2` <blockquote> ## [0.7.1](tket2-v0.7.0...tket2-v0.7.1) - 2025-01-10 ### Bug Fixes - remove unicode pi symbols in rotation extension (#743) </blockquote> ## `tket2-hseries` <blockquote> ## [0.9.0](tket2-hseries-v0.8.0...tket2-hseries-v0.9.0) - 2025-02-12 ### Bug Fixes - Use `RemoveDeadFuncsPass` instead of deprecated `remove_polyfuncs()` (#759) - nondeterminism in lazify-measure (#766) ### New Features - *(tket2-hseries)* Add `tket2.wasm` extension (#737) - force-order qfree early and qalloc late. (#762) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #758 .