Morph addressbook to entrybook #21

epicfailname · 2019-02-25T15:14:46Z

Morphs application and features to operate on entries for links and feeds, instead of persons and addresses

Person -> Entry
AddressBook -> EntryBook
Name -> Title
Phone -> Comment
Email -> Link
Address (made invisible, unused field. Kept to pass regression tests, and as a placeholder for future properties of Entry)
Minimal changes made to reflect the morphed state on the user-side
Several internal functions and names retain their old names

Note to self: Changing fields in Entry must change equivalent labels in PersonCard/PersonCardHandle

NameContainsKeywordsPredicate -> TitleContainsKeyWordsPredicate

addressbook.json -> entrybook.json

Person -> Entry AddressBook -> EntryBook

It will be created automatically if not found, with the correct names and fields (corresponding to entry book). Important to note that for this to take effect, you'll need to delete preference.json and data/addressbook.json first.

Person -> Entry AddressBook -> EntryBook

"Address" still present internally, just not visible

Internally, "Address" field is now a optional input field (still works if you use "add" command with "a/" prefix), with a default placeholder if none is given. Tests requiring non-null "Address" field are commented off.

Title: n/ -> ti/ (Used to be Name) Comment: p/ -> c/ (Used to be Phone) Link: e/ -> l/ (Used to be Email)

Title: Accepts non-empty, any value Comment: Accepts non-empty, any value (Might want to make optional field in future) Link: protocol//path

GuiRobot wait time set back to 250ms

epicfailname · 2019-02-27T09:57:10Z

Resolves #30
Resolves part of #19

thomastanck

LGTM

rlrh

Looks good, just that it'd be better to add some comments on important changes for future reference.

src/main/java/seedu/address/ui/EntryCard.java

Combining requested changes into one review

rlrh

Looks good. But I think ParserUtil#parseAddress should not be modified, instead AddCommandParser should handle a missing address argument through Optional.orElse, and another benefit is that EditCommandParser will not need to be modified too.
Also, do you want to mark this PR as resolving part of #19?

rlrh · 2019-02-28T03:19:22Z

src/main/java/seedu/address/ui/EntryCard.java

+        title.setText(entry.getTitle().fullTitle);
+        comment.setText(entry.getComment().value);
+        address.setText(entry.getAddress().value);
+        address.setManaged(false);


What does this line do? I think we should add a comment about it here for future reference.

Makes the Address label invisible, graphics pipeline will not manage it. And agreed, will do

rlrh · 2019-02-28T03:19:57Z

src/main/resources/view/MainWindow.fxml

@@ -12,7 +12,7 @@
 <?import javafx.scene.layout.VBox?>

 <fx:root type="javafx.stage.Stage" xmlns="http://javafx.com/javafx/8" xmlns:fx="http://javafx.com/fxml/1"
-         title="Address App" minWidth="450" minHeight="600" onCloseRequest="#handleExit">
+         title="Entrybook App" minWidth="450" minHeight="600" onCloseRequest="#handleExit">


Small detail but since it's user facing, should we rename this to "Readme App" or just "Readme" instead? Or we can do it in another PR once we have settled on a name.

rlrh · 2019-02-28T03:30:47Z

src/main/java/seedu/address/logic/parser/AddCommandParser.java

+        Comment comment = ParserUtil.parseComment(argMultimap.getValue(PREFIX_COMMENT).get());
+        Link link = ParserUtil.parseLink(argMultimap.getValue(PREFIX_LINK).get());
+        // Address address = ParserUtil.parseAddress(argMultimap.getValue(PREFIX_ADDRESS).get());
+        Address address = ParserUtil.parseAddress(argMultimap.getValue(PREFIX_ADDRESS));


So as not to let the changes propagate too far, instead of modifying ParserUtil, we can process a missing address argument right here using Optional.orElse:
Address address = ParserUtil.parseAddress(argMultimap.getValue(PREFIX_ADDRESS).orElse("Default address"));
So ParserUtil#parseAddress can still retain the same signature as others - Address parseAddress(String address) instead of Address parseAddress(Optional<String> maybeAddress)

rlrh · 2019-02-28T03:36:01Z

src/main/java/seedu/address/logic/parser/EditCommandParser.java

        }
        if (argMultimap.getValue(PREFIX_ADDRESS).isPresent()) {
-            editPersonDescriptor.setAddress(ParserUtil.parseAddress(argMultimap.getValue(PREFIX_ADDRESS).get()));
+            editPersonDescriptor.setAddress(ParserUtil.parseAddress(argMultimap.getValue(PREFIX_ADDRESS)));


If you take my suggestion to handle a missing address argument in AddCommandParser, then this line can go back to the original.

Change title to Readme

epicfailname added 3 commits February 25, 2019 21:10

Refactor Person -> Entry

dcdef32

Refactor Name -> Title

c2f5829

Note to self: Changing fields in Entry must change equivalent labels in PersonCard/PersonCardHandle

Refactor Email -> Link

4f31e47

epicfailname force-pushed the morph-addressback-to-entrybook branch from f860f93 to 4f31e47 Compare February 25, 2019 15:40

epicfailname added 25 commits February 26, 2019 00:01

Refactor Phone -> Comment

54bd083

Fix checkstyle bugs

9e8b9d6

Refactor NameContains... -> TitleContains..

ca49f07

NameContainsKeywordsPredicate -> TitleContainsKeyWordsPredicate

Change default data file path

86d4e8a

addressbook.json -> entrybook.json

Fix checkstyle bugs

50bff52

Refactor AddressBook -> EntryBook

c4dd87e

Fix checkstyle bugs

1607160

Refactor .json files for Storage tests

b0a209f

Person -> Entry AddressBook -> EntryBook

Refactor Json..AddressBook.. -> Json..EntryBook..

7f0a97b

Remove .json config and data files

a6becf7

It will be created automatically if not found, with the correct names and fields (corresponding to entry book). Important to note that for this to take effect, you'll need to delete preference.json and data/addressbook.json first.

Refactor Person Excetions, Person -> Entry

e30dce6

Refactor JsonAdaptedPerson -> JsonAdaptedEntry

a42cc92

Refactor UI name Person -> Entry

67e99d1

Refactor AddressBookParser -> EntryBookParser

0dff1da

Refactor rename tests

c9176d9

Person -> Entry AddressBook -> EntryBook

Toggle visibility of "Address" field

b0d698a

"Address" still present internally, just not visible

Refactor rename app window title/ status bar info

d0a4902

Remove visibility of "Address" field in Entry

f6d33dd

Internally, "Address" field is now a optional input field (still works if you use "add" command with "a/" prefix), with a default placeholder if none is given. Tests requiring non-null "Address" field are commented off.

Refactor argument prefixes

e55dc29

Title: n/ -> ti/ (Used to be Name) Comment: p/ -> c/ (Used to be Phone) Link: e/ -> l/ (Used to be Email)

Updated parsers for Title, Comment and Link

088729d

Title: Accepts non-empty, any value Comment: Accepts non-empty, any value (Might want to make optional field in future) Link: protocol//path

Remove debugging code

59e57d1

Fix checkstyle bugs

5521a18

Refactor UI messages for commands

7f39bd0

Revert debugging code changes

82a4f5a

GuiRobot wait time set back to 250ms

Fix checkstyle bugs

5ed2a7a

epicfailname changed the title ~~[WIP] Morph addressback to entrybook~~ Morph addressbook to entrybook Feb 27, 2019

thomastanck self-requested a review February 27, 2019 10:47

Fix dead link and incorrect URL example

fcdc94d

epicfailname added this to the v1.1 milestone Feb 27, 2019

epicfailname self-assigned this Feb 27, 2019

thomastanck approved these changes Feb 27, 2019

View reviewed changes

rlrh previously requested changes Feb 28, 2019

View reviewed changes

src/main/java/seedu/address/ui/EntryCard.java Outdated Show resolved Hide resolved

rlrh self-requested a review February 28, 2019 03:17

rlrh requested changes Feb 28, 2019

View reviewed changes

Refactor to-be deprecated parser for Address

7eaaf30

Change title to Readme

rlrh approved these changes Feb 28, 2019

View reviewed changes

epicfailname merged commit e796313 into CS2103-AY1819S2-W10-1:master Feb 28, 2019

epicfailname mentioned this pull request Feb 28, 2019

As a heavy user, I want to have a tagging system #30

Closed

epicfailname deleted the morph-addressback-to-entrybook branch March 19, 2019 16:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Morph addressbook to entrybook #21

Morph addressbook to entrybook #21

epicfailname commented Feb 25, 2019 •

edited

Loading

epicfailname commented Feb 27, 2019 •

edited

Loading

thomastanck left a comment

rlrh left a comment

rlrh left a comment •

edited

Loading

rlrh Feb 28, 2019

epicfailname Feb 28, 2019

rlrh Feb 28, 2019

rlrh Feb 28, 2019 •

edited

Loading

epicfailname Feb 28, 2019

rlrh Feb 28, 2019

Morph addressbook to entrybook #21

Morph addressbook to entrybook #21

Conversation

epicfailname commented Feb 25, 2019 • edited Loading

epicfailname commented Feb 27, 2019 • edited Loading

thomastanck left a comment

Choose a reason for hiding this comment

rlrh left a comment

Choose a reason for hiding this comment

rlrh left a comment • edited Loading

Choose a reason for hiding this comment

rlrh Feb 28, 2019

Choose a reason for hiding this comment

epicfailname Feb 28, 2019

Choose a reason for hiding this comment

rlrh Feb 28, 2019

Choose a reason for hiding this comment

rlrh Feb 28, 2019 • edited Loading

Choose a reason for hiding this comment

epicfailname Feb 28, 2019

Choose a reason for hiding this comment

rlrh Feb 28, 2019

Choose a reason for hiding this comment

epicfailname commented Feb 25, 2019 •

edited

Loading

epicfailname commented Feb 27, 2019 •

edited

Loading

rlrh left a comment •

edited

Loading

rlrh Feb 28, 2019 •

edited

Loading