forked from nus-cs2103-AY1819S2/addressbook-level4
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update add entry behaviour #61
Merged
epicfailname
merged 13 commits into
CS2103-AY1819S2-W10-1:master
from
epicfailname:update-add-entry-behaviour
Mar 11, 2019
Merged
Update add entry behaviour #61
epicfailname
merged 13 commits into
CS2103-AY1819S2-W10-1:master
from
epicfailname:update-add-entry-behaviour
Mar 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with tests to match behaviour
To-be-deprecated Address field also has default as empty String
Pull Request Test Coverage Report for Build 222
💛 - Coveralls |
Make is more persmissive, such that file paths without double forward slashes are also valid. Also remove debugging code.
thomastanck
reviewed
Mar 11, 2019
thomastanck
approved these changes
Mar 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #42
Resolves #43
Resolves part of #19
Summary of changes
Comment
toDescription
Title
andDescription
not compulsory fields when adding anEntry
add
oredit
to an entryLink
,Description
) have two separate validity regex checks for its Stringvalue
Entry
'sisSameEntry()
functionTitle
and (Comment
orLink
) for comparisonLink
for comparisonLink
user-input and construction validation regex to be more permissive//
to be optional