View articles offline if available #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomastanck
force-pushed
the
offline-view
branch
2 times, most recently
from
6ee0aa0 to
72a5761
Compare
Pull Request Test Coverage Report for Build 328
💛 - Coveralls |
thomastanck
force-pushed
the
offline-view
branch
2 times, most recently
from
df22bfc to
26501b6
Compare
thomastanck
force-pushed
the
offline-view
branch
from
26501b6 to
ed0efca
Compare
This was referenced Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #52 and #54.
Resolves part of #19.
Adds
offlineLinkfield toEntry, andBrowserPanelviewsofflineLinkif it exists.Summary of changes
offlineLinktoEntryofflineLinktoBrowserPanelJsonAdaptedEntryso thatofflineLinkwill be saved to disk.htmlextension to local filenames so thatWebEngineviews them properly.