Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add error style to result display #9

Merged
merged 14 commits into from
Feb 19, 2019
Merged

Add error style to result display #9

merged 14 commits into from
Feb 19, 2019

Conversation

epicfailname
Copy link

When an invalid command is inputted, the result display will change its style to reflect the invalid command

@thomastanck thomastanck self-requested a review February 18, 2019 17:23
thomastanck
thomastanck requested changes Feb 18, 2019
View reviewed changes
Copy link

@thomastanck thomastanck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good unit tests. Could we add this style check to the command and system tests as well? There's probably a way to add them to the util functions straight away as most of the tests assert success/failure through them.

src/main/java/seedu/address/ui/ResultDisplay.java Outdated Show resolved Hide resolved
src/test/java/seedu/address/ui/ResultDisplayTest.java Show resolved Hide resolved
@rlrh rlrh added this to the Mid-v1.1 milestone Feb 19, 2019
@epicfailname epicfailname merged commit f01a15f into CS2103-AY1819S2-W10-1:master Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomastanck thomastanck thomastanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Mid-v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@epicfailname @thomastanck @rlrh