Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aco paper branch apr2021 #153

Merged
merged 25 commits into from
May 24, 2021

Conversation

paul-mchugh
Copy link
Member

Adds the improvements from the ACO paper the the main repo.

@@ -52,6 +52,20 @@ class SequentialListScheduler : public ListScheduler {
bool ChkInstLglty_(SchedInstruction *inst) const override;
};

// A list scheduler that schedules the instruction with the top heuristic value
// Unalike ListScheduler this class considers instructions that are no ready
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is a typo here: ListScheduler this class considers instructions that are no ready
Looks like the no needs to be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed it

Copy link
Contributor

@VladM1076 VladM1076 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read through the changes a few times, and other than a typo in list_sched.h:56 I do not see any issues with these changes. Good work!

Copy link
Member

@Quincunx271 Quincunx271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know a lot about our ACO code, but I made some nitpicks.

@paul-mchugh paul-mchugh force-pushed the aco_paper_branch_apr2021 branch from 67c284a to 98a2517 Compare May 21, 2021 21:20
Copy link
Member

@Quincunx271 Quincunx271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Quincunx271 Quincunx271 mentioned this pull request May 24, 2021
3 tasks
@paul-mchugh paul-mchugh force-pushed the aco_paper_branch_apr2021 branch from 6ca97ff to ff4a61b Compare May 24, 2021 17:39
@paul-mchugh paul-mchugh merged commit 43931a1 into CSUS-LLVM:master May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants