-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aco paper branch apr2021 #153
Aco paper branch apr2021 #153
Conversation
… are violated, added profiling print stmts
@@ -52,6 +52,20 @@ class SequentialListScheduler : public ListScheduler { | |||
bool ChkInstLglty_(SchedInstruction *inst) const override; | |||
}; | |||
|
|||
// A list scheduler that schedules the instruction with the top heuristic value | |||
// Unalike ListScheduler this class considers instructions that are no ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there is a typo here: ListScheduler this class considers instructions that are no ready
Looks like the no
needs to be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I read through the changes a few times, and other than a typo in list_sched.h:56 I do not see any issues with these changes. Good work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know a lot about our ACO code, but I made some nitpicks.
67c284a
to
98a2517
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6ca97ff
to
ff4a61b
Compare
Adds the improvements from the ACO paper the the main repo.