forked from openedx/brand-openedx
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge changes in from sticky footer, fonts and typography based on the v2.1.2
version of brand-edx.org
#9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ducateworkforce Add some additional font-style and sticky footer to a v2.1.2 of `brand-edx.org` for nutmeg release.
…ducateworkforce Make sure that we deploy to npm for this nutmeg release.
…ducateworkforce Release to npm whenever we make a release.
Received this error message when the release workflow ran. ``` [semantic-release]: node version >=20.8.1 is required. Found v18.20.1. See https://github.com/semantic-release/semantic-release/blob/master/docs/support/node-version.md for more details and solutions. ```
…ducateworkforce Node version for semantic-release needs to be at least 20.
Error ``` [3:13:35 PM] [semantic-release] › ℹ This test run was triggered on the branch refs/tags/2.1.2-nutmeg.2.1, while semantic-release is configured to only publish from master, alpha, therefore a new version won’t be published. ```
…ducateworkforce Received error when trying to run workflow release for branch.
…ducateworkforce Be able to run `semantic-release` on develop branches.
Error: ``` [3:47:28 PM] [semantic-release] › ℹ This test run was triggered on the branch develop/nutmeg.master, while semantic-release is configured to only publish from master, alpha, therefore a new version won’t be published. ``` Looks like `semantic-release` has specific branches that it uses to release from. https://github.com/semantic-release/semantic-release/blob/master/docs/usage/configuration.md#branches
…ducateworkforce Make sure the `semantic-release` adheres to specific branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a lot of changes for changing the
semantic-release
Github workflow configuration for the release to npm in trying to get this right.It appears that
semantic-release
relies on specific branches.https://github.com/semantic-release/semantic-release/blob/master/docs/usage/configuration.md#branches
Recipe for
semantic-release
for Github workflow.https://github.com/semantic-release/semantic-release/blob/master/docs/recipes/ci-configurations/github-actions.md