Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge changes in from sticky footer, fonts and typography based on the v2.1.2 version of brand-edx.org #9

Merged
merged 16 commits into from
Apr 11, 2024

Conversation

ztraboo
Copy link

@ztraboo ztraboo commented Apr 11, 2024

There were a lot of changes for changing the semantic-release Github workflow configuration for the release to npm in trying to get this right.

It appears that semantic-release relies on specific branches.
https://github.com/semantic-release/semantic-release/blob/master/docs/usage/configuration.md#branches

Recipe for semantic-release for Github workflow.
https://github.com/semantic-release/semantic-release/blob/master/docs/recipes/ci-configurations/github-actions.md

ztraboo added 16 commits April 10, 2024 09:25
…ducateworkforce

Add some additional font-style and sticky footer to a v2.1.2 of `brand-edx.org` for nutmeg release.
…ducateworkforce

Make sure that we deploy to npm for this nutmeg release.
…ducateworkforce

Release to npm whenever we make a release.
Received this error message when the release workflow ran.

```
[semantic-release]: node version >=20.8.1 is required. Found v18.20.1.
See https://github.com/semantic-release/semantic-release/blob/master/docs/support/node-version.md for more details and solutions.
```
…ducateworkforce

Node version for semantic-release needs to be at least 20.
Error
```
[3:13:35 PM] [semantic-release] › ℹ  This test run was triggered on the branch refs/tags/2.1.2-nutmeg.2.1, while semantic-release is configured to only publish from master, alpha, therefore a new version won’t be published.
```
…ducateworkforce

Received error when trying to run workflow release for branch.
…ducateworkforce

Be able to run `semantic-release` on develop branches.
Error:
```
[3:47:28 PM] [semantic-release] › ℹ  This test run was triggered on the branch develop/nutmeg.master, while semantic-release is configured to only publish from master, alpha, therefore a new version won’t be published.
```

Looks like `semantic-release` has specific branches that it uses to release from.
https://github.com/semantic-release/semantic-release/blob/master/docs/usage/configuration.md#branches
…ducateworkforce

Make sure the `semantic-release` adheres to specific branches.
@ztraboo ztraboo self-assigned this Apr 11, 2024
@ztraboo ztraboo added the enhancement New feature or request label Apr 11, 2024
@ztraboo ztraboo added this to the cu-release/nutmeg.2 milestone Apr 11, 2024
@ztraboo ztraboo merged commit 2fddc6d into master Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant