Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes for cached model internals. #213

Merged
merged 3 commits into from
Oct 26, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions andes/core/model.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,9 @@ def refresh(self, name=None):
----------
name : str, list, optional
name or list of cached to refresh, by default None for refreshing all

TODO: bug found in Example notebook 2. Time domain initialization fails
after refreshing.
"""
if name is None:
for name in self._callbacks.keys():
Expand Down
6 changes: 6 additions & 0 deletions andes/system.py
Original file line number Diff line number Diff line change
Expand Up @@ -710,6 +710,12 @@ def store_adder_setter(self, models):
if not mdl.n:
continue

# Fixes an issue if the cache was manually built but stale
# after assigning addresses for simulation
# Assigning memory will affect the cache of `v_adders` and `e_adders`.

mdl.cache.refresh()

# ``getters` that retrieve variable values from DAE
for var in mdl.cache.v_getters.values():
self._getters[var.v_code].append(var)
Expand Down
Loading